Help message revamp #161
Draft
Help message revamp #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,8 +66,12 @@ impl Clone for Box<dyn Autocomplete> { | |||
| /// Empty struct and implementation of Autocomplete trait. Used for the default | |||
| /// autocompleter of `Text` prompts. | |||
| #[derive(Clone, Default)] | |||
| #[deprecated( | |||
There was a problem hiding this comment.
I am very comfortable with it.
There was a problem hiding this comment.
Sorry I'm not sure if this is a "I'm comfortable with adding this" or "I'm comfortable with the struct, we don't need the deprecated" lol
For context, the only use was as the default value inside the prompt impl when the prompt config was None, so I even thought of just removing the NoAutoComplete struct altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143